Seafile Pro Server Notification on folder upload to share link

causefx · May 13, 2022, 9:52pm

Server 9.0.5 Pro

When uploading a folder via the Share link, no notifications are generated. Although, single file uploads are generated.

causefx · May 18, 2022, 9:42pm

bump… for anyone out there…

causefx · May 25, 2022, 10:33pm

The issue that I can see is that the API calls get_file_id_by_path after uploading either a file or a folder. The problem with that is - if the uploaded action was a file only, it will be okay as the function will return the id of the uploaded file. When uploading a folder on the other hand, the function will be called using the folder path… i.e.

file_path: /Upload/JoeMomma

resulting in the error:

{"error_msg":"File /Upload/JoeMomma not found."}

I think the solution would be either checking if the file_path is a folder first and validating that way or looping the function for each file uploaded.
~~The function in question is:~~
~~https://github.com/haiwen/seahub/blob/df6f44b8a1673f237637481963ee5484820b49ee/seahub/views/ajax.py#L297~~
~~Line 337 is where the function is called.~~

See answer for correct file…

causefx · May 25, 2022, 11:37pm

I went ahead and dove in further - I ended up fixing the issue by editing this file:

github.com

haiwen/seahub/blob/05596a0f4ac981482578189115f4cc05c93f6bf1/seahub/api2/endpoints/share_links.py#L969

    
      
          parent_dir = upload_link.path
          if seafile_api.check_permission_by_path(repo_id, parent_dir, upload_link.username) != 'rw':
              error_msg = 'Permission denied.'
              return api_error(status.HTTP_403_FORBIDDEN, error_msg)
          
          
file_path = request.data.get('file_path')
          if not file_path:
              error_msg = 'file_path invalid.'
              return api_error(status.HTTP_400_BAD_REQUEST, error_msg)
          
          
file_id = seafile_api.get_file_id_by_path(repo_id, file_path)
          if not file_id:
              error_msg = 'File %s not found.' % file_path
              return api_error(status.HTTP_404_NOT_FOUND, error_msg)
          
          
upload_file_successful.send(sender=None,
                                      repo_id=repo_id,
                                      file_path=file_path,
                                      owner=upload_link.username)
          
          
return Response({'success': True})

I ended up removing lines 969-972 and replacing with this:

file_id = seafile_api.get_file_id_by_path(repo_id, file_path)
dir_id = seafile_api.get_dir_id_by_path(repo_id, file_path)
if not file_id and not dir_id:
	error_msg = 'File/Folder %s not found.' % file_path
	return api_error(status.HTTP_404_NOT_FOUND, error_msg)

And now notifications for folder uploads are now coming through.