Seafile-controller -t functionality broken on 8.x

Ultima · January 31, 2021, 9:49pm

Running seafile-controller -t will geneate the following:
seaf-server: invalid option – L
usage: seaf-server [-c config_dir] [-d seafile_dir]
failed to run “seaf-server -t” [256]

Furthermore, there is no config testing logic in seaf-server and also does not accept the -t option.

github.com

haiwen/seafile-server/blob/v8.0.3-server/controller/seafile-controller.c#L655


             const char *seafile_dir)
{
    char buf[1024];
    GError *error = NULL;
    int retcode = 0;
    char *child_stdout = NULL;
    char *child_stderr = NULL;


    snprintf (buf,
          sizeof(buf),
          "seaf-server -F \"%s\" -c \"%s\" -d \"%s\" -L \"%s\" -t -f",
          central_config_dir,
          ccnet_dir,
          seafile_dir,
          topdir);


    g_spawn_command_line_sync (buf,
                               &child_stdout,
                               &child_stderr,
                               &retcode,
                               &error);

“seaf-server -F “%s” -c “%s” -d “%s” -L “%s” -t -f”,

Valid args in seaf-server are here:

github.com

haiwen/seafile-server/blob/v8.0.3-server/server/seaf-server.c#L1173


    const char *debug_str = NULL;
    int daemon_mode = 1;


#ifdef WIN32
    argv = get_argv_utf8 (&argc);
#endif


    while ((c = getopt_long (argc, argv, short_options, 
                             long_options, NULL)) != EOF)
    {
        switch (c) {
        case 'h':
            exit (1);
            break;
        case 'v':
            exit (1);
            break;
        case 'c':
            ccnet_dir = optarg;
            break;
        case 'd':

Also, there is the ability to select debugging mode in seaf-server via the -D option, and in seafile-controller, the -G option is how you set this, however, seafile-controller does not set this arg when executing the seaf-server command.

The log level could be using another function to set via seafile_log_init but I didn’t dig into this deep enough to understand how this works.

Jonathan · February 1, 2021, 4:03am

The -t option issue is a bug. We’ll fix it.

For the -G option, it’s rarely needed. Usually you can set SEAFILE_DEBUG environment variable instead.

Ultima · February 1, 2021, 6:05am

Hey Jonathan,

Thanks for the quick response.

Is there a more suitable place you prefer bug reports to be created like this?

Jonathan · February 15, 2021, 6:16am

@Ultima You can submit bugs on Github: https://github.com/haiwen/seafile/issues